Skip to content

Deprecate 1-Wire SysBus (ADR-0019)#63513

Merged
epenet merged 4 commits intodevfrom
frenck-2022-0039
Jan 6, 2022
Merged

Deprecate 1-Wire SysBus (ADR-0019)#63513
epenet merged 4 commits intodevfrom
frenck-2022-0039

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jan 5, 2022

Breaking change

Using the 1-Wire via SysBus is deprecated and will be removed
in Home Assistant Core 2022.6; this integration is being adjusted to comply
with Architectural Decision Record 0019, more information can be found here:

https://github.com/home-assistant/architecture/blob/master/adr/0019-GPIO.md

Proposed change

Add deprecation notice because of ADR-0019

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @garbled1, @epenet, mind taking a look at this pull request as it has been labeled with an integration (onewire) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck marked this pull request as ready for review January 5, 2022 19:07
@frenck frenck requested a review from epenet as a code owner January 5, 2022 19:07
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 5, 2022
@epenet
Copy link
Copy Markdown
Contributor

epenet commented Jan 5, 2022

Could we add a note to say: "install owserver"?
And what happens for migration to custom component if we keep the domain for owserver implementation?
I'm not sure if there are other components on ADR19 that have this dual access.

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jan 5, 2022

Could we add a note to say: "install owserver"?

Feel free to suggest an edit.

And what happens for migration to custom component if we keep the domain for owserver implementation?

It would need a different domain (which is recommended anyways).

I'm not sure if there are other components on ADR19 that have this dual access.

🤷

@gwww
Copy link
Copy Markdown
Contributor

gwww commented Jan 5, 2022

The PR comment says it will be removed in 2022.4 while the code warning says 2022.6.

@frenck
Copy link
Copy Markdown
Member Author

frenck commented Jan 5, 2022

@gwww

The PR comment says it will be removed in 2022.4 while the code warning says 2022.6.

Adjusted, thanks! Did a bunch of these, so copy-pasted a lot 😄

Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warning in async_setup_entry should be removed.
I would maybe adjust the warning in onewirehub to encourage users to migrate but that is maybe optional.

frenck and others added 2 commits January 6, 2022 11:59
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@frenck frenck requested a review from epenet January 6, 2022 10:59
@epenet epenet merged commit 53d86d4 into dev Jan 6, 2022
@epenet epenet deleted the frenck-2022-0039 branch January 6, 2022 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking-change cla-signed integration: onewire small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants