Skip to content

Handle no enabled ipv4 addresses in the network integration#63416

Merged
balloob merged 2 commits into
home-assistant:devfrom
bdraco:source_address_no_ipv4
Jan 5, 2022
Merged

Handle no enabled ipv4 addresses in the network integration#63416
balloob merged 2 commits into
home-assistant:devfrom
bdraco:source_address_no_ipv4

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jan 5, 2022

Proposed change

Fixes

2022-01-03 13:46:08 ERROR (MainThread) [homeassistant.setup] Error during setup of component http
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/setup.py", line 229, in _async_setup_component
    result = await task
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/components/http/__init__.py", line 192, in async_setup
    local_ip = await async_get_source_ip(hass)
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/components/network/__init__.py", line 35, in async_get_source_ip
    return source_ip if source_ip in all_ipv4s else all_ipv4s[0]
IndexError: list index out of range

Reported here: https://community.home-assistant.io/t/2021-12-new-configuration-menu-the-button-entity-and-gorgeous-area-cards/365680/776?u=bdraco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Fixes
```
2022-01-03 13:46:08 ERROR (MainThread) [homeassistant.setup] Error during setup of component http
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/setup.py", line 229, in _async_setup_component
    result = await task
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/components/http/__init__.py", line 192, in async_setup
    local_ip = await async_get_source_ip(hass)
  File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/components/network/__init__.py", line 35, in async_get_source_ip
    return source_ip if source_ip in all_ipv4s else all_ipv4s[0]
IndexError: list index out of range
```

Reported here: https://community.home-assistant.io/t/2021-12-new-configuration-menu-the-button-entity-and-gorgeous-area-cards/365680/776?u=bdraco
@bdraco bdraco added this to the 2021.12.8 milestone Jan 5, 2022
@bdraco bdraco mentioned this pull request Jan 5, 2022
@balloob balloob merged commit e6e200f into home-assistant:dev Jan 5, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants