Skip to content

Handle missing monitored users in Plex options#63411

Merged
balloob merged 1 commit into
home-assistant:devfrom
jjlawren:plex_fix_removed_shared_users
Jan 4, 2022
Merged

Handle missing monitored users in Plex options#63411
balloob merged 1 commit into
home-assistant:devfrom
jjlawren:plex_fix_removed_shared_users

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Jan 4, 2022

Proposed change

If a user was enabled in the Plex config options but the Plex account was later deleted/removed, it would cause issues when trying to edit the config options. This change trims those "missing" accounts from the defaults provided to the frontend.

Addresses second reported issue in #63354.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit 0585207 into home-assistant:dev Jan 4, 2022
@balloob balloob mentioned this pull request Jan 5, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 6, 2022
@jjlawren jjlawren deleted the plex_fix_removed_shared_users branch May 31, 2022 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants