Skip to content

Work around ingress glitch with 304 responses #63355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Jan 4, 2022
+1 −1
Merged

Work around ingress glitch with 304 responses #63355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
421dd8f
Work around ingress glitch with 304 responses
masto Jan 4, 2022
5b764e4
Update homeassistant/components/hassio/ingress.py
balloob Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/hassio/ingress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ async def _handle_request(
if (
hdrs.CONTENT_LENGTH in result.headers
and int(result.headers.get(hdrs.CONTENT_LENGTH, 0)) < 4194000
):
) or result.status in (204, 304):
Copy link
Copy Markdown
Member

@ludeeus ludeeus Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use (HTTPStatus.NO_CONTENT, HTTPStatus.NOT_MODIFIED) and should have a test that proves that these 2 statuses return Response and not StreamResponse

# Return Response
body = await result.read()
return web.Response(
Expand Down