Skip to content

Bump micloud to 0.5#63348

Merged
frenck merged 1 commit into
home-assistant:devfrom
starkillerOG:xiaomi_miio_cloud_fix
Jan 4, 2022
Merged

Bump micloud to 0.5#63348
frenck merged 1 commit into
home-assistant:devfrom
starkillerOG:xiaomi_miio_cloud_fix

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Bump micloud to version 0.5:
Squachen/micloud@v_0.4...v_0.5

Apperently Xiaomi implemented rc4 encryption in their protocol around dec 31th 2021.
This breaks the cloud setup method of xiaomi miio integration.
This version bump implements this rc4 encrpytion to fix the integration again.

Please consider for a bugfix release of HomeAssistant since xiaomi miio is a fairly large integration (used by many) and it broke overnight due to server update of xiaomi.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added bugfix dependency Pull requests marked as a dependency upgrade integration: xiaomi_miio small-pr PRs with less than 30 lines. labels Jan 4, 2022
@probot-home-assistant probot-home-assistant Bot added the dependency-bump Pull requests that update a dependency file label Jan 4, 2022
@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title bump micloud to 0.5 Bump micloud to 0.5 Jan 4, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 4, 2022
@thecode thecode added this to the 2021.12.8 milestone Jan 4, 2022
@frenck frenck merged commit 4d59c1b into home-assistant:dev Jan 4, 2022
balloob pushed a commit that referenced this pull request Jan 4, 2022
@balloob balloob mentioned this pull request Jan 4, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file integration: xiaomi_miio small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xiaomi Miio Integration

8 participants