Skip to content

Bump flux_led to 0.27.32 to fix incorrect strip order on A2 devices#63262

Merged
frenck merged 2 commits into
home-assistant:devfrom
bdraco:flux_led_fix_a2_strips
Jan 3, 2022
Merged

Bump flux_led to 0.27.32 to fix incorrect strip order on A2 devices#63262
frenck merged 2 commits into
home-assistant:devfrom
bdraco:flux_led_fix_a2_strips

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jan 3, 2022

Proposed change

  • Changelog: lightinglibs/flux_led@0.27.28...0.27.32

  • These devices use yet another strip ordering. It is almost the same as the A1 models, but replaces LB1914 with WS2815, APA102, TM1914, UCS2904B so we wouldn't report colors correctly on the last 3 types.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- These devices use yet another strip ordering
@probot-home-assistant probot-home-assistant Bot added bugfix dependency Pull requests marked as a dependency upgrade integration: flux_led small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file labels Jan 3, 2022
@probot-home-assistant
Copy link
Copy Markdown

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco added this to the 2021.12.8 milestone Jan 3, 2022
@bdraco bdraco changed the title Bump flux_led to 0.27.31 to fix incorrect strip order on A2 devices Bump flux_led to 0.27.32 to fix incorrect strip order on A2 devices Jan 3, 2022
@frenck frenck merged commit 78d7387 into home-assistant:dev Jan 3, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file integration: flux_led small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants