Skip to content

Fix CO/CO2 sensors mixup in Google Assistant#63152

Merged
frenck merged 2 commits into
home-assistant:devfrom
ryborg:patch-1
Jan 4, 2022
Merged

Fix CO/CO2 sensors mixup in Google Assistant#63152
frenck merged 2 commits into
home-assistant:devfrom
ryborg:patch-1

Conversation

@ryborg
Copy link
Copy Markdown
Contributor

@ryborg ryborg commented Dec 31, 2021

Breaking change

Proposed change

Not only am I not sure how to ask Google Assistant how to report the level of carbon dioxide in my living room (exposed restful sensor, device_class: carbon_dioxide) but the sensor classes were mixed up here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Not only am I not sure how to ask Google Assistant how to report the level of carbon dioxide in my living room (exposed restful sensor, device_class: carbon_dioxide) but the sensor classes were mixed up here.
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @ryborg,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (google_assistant) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@allenporter
Copy link
Copy Markdown
Contributor

There appear to be some test failures to resolve

@ryborg
Copy link
Copy Markdown
Contributor Author

ryborg commented Jan 1, 2022

Also, I'll have to raise as an issue, but I can't confirm that these sensors are working in assistant. So it's hard to label it as a bug fix. It's an obvious coding error is all.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 2, 2022

@ryborg Could you please fix the failing test? Thanks! 👍

@ryborg
Copy link
Copy Markdown
Contributor Author

ryborg commented Jan 2, 2022 via email

@frenck
Copy link
Copy Markdown
Member

frenck commented Jan 2, 2022

I can't test.

I was not asking for a test with an device, but our automated test suite is failing:

image

Meaning this code change is incomplete, as the unittest need to be adjusted as well.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 4, 2022
@frenck frenck changed the title Update trait.py Fix CO/CO2 sensors mixup in Google Assistant Jan 4, 2022
@frenck frenck added this to the 2021.12.8 milestone Jan 4, 2022
@frenck frenck merged commit 5f5adff into home-assistant:dev Jan 4, 2022
balloob pushed a commit that referenced this pull request Jan 4, 2022
Co-authored-by: Franck Nijhof <git@frenck.dev>
@balloob balloob mentioned this pull request Jan 4, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed core integration: google_assistant small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants