Fix CO/CO2 sensors mixup in Google Assistant#63152
Merged
Merged
Conversation
Not only am I not sure how to ask Google Assistant how to report the level of carbon dioxide in my living room (exposed restful sensor, device_class: carbon_dioxide) but the sensor classes were mixed up here.
Contributor
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration ( |
Contributor
|
There appear to be some test failures to resolve |
Contributor
Author
|
Also, I'll have to raise as an issue, but I can't confirm that these sensors are working in assistant. So it's hard to label it as a bug fix. It's an obvious coding error is all. |
Member
|
@ryborg Could you please fix the failing test? Thanks! 👍 |
Contributor
Author
|
All I have been able to do is point out the obvious problem with the code.
I can't test.
…On Sun., Jan. 2, 2022, 10:38 a.m. Franck Nijhof, ***@***.***> wrote:
@ryborg <https://github.com/ryborg> Could you please fix the failing
test? Thanks! 👍
—
Reply to this email directly, view it on GitHub
<#63152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYBFIRPD264NPI2HPD33KTUUBWQ7ANCNFSM5LBV537A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
MartinHjelmare
approved these changes
Jan 4, 2022
frenck
approved these changes
Jan 4, 2022
balloob
pushed a commit
that referenced
this pull request
Jan 4, 2022
Co-authored-by: Franck Nijhof <git@frenck.dev>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
Not only am I not sure how to ask Google Assistant how to report the level of carbon dioxide in my living room (exposed restful sensor, device_class: carbon_dioxide) but the sensor classes were mixed up here.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: