Skip to content

Fix systemmonitor CPU temp for Armbian on PineA64#63111

Merged
frenck merged 1 commit into
home-assistant:devfrom
ktaragorn:dev
Jan 2, 2022
Merged

Fix systemmonitor CPU temp for Armbian on PineA64#63111
frenck merged 1 commit into
home-assistant:devfrom
ktaragorn:dev

Conversation

@ktaragorn
Copy link
Copy Markdown
Contributor

Proposed change

Fix temperature detection for Armbian on PineA64

>>> psutil.sensors_temperatures()
{'cpu0_thermal': [shwtemp(label='', current=44.557, high=90.0, critical=90.0)], 'gpu0_thermal': [shwtemp(label='', current=43.972, high=None, critical=None)], 'gpu1_thermal': [shwtemp(label='', current=44.206, high=None, critical=None)], 'axp813_adc': [shwtemp(label='', current=29.7, high=None, critical=None)]}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

```
>>> psutil.sensors_temperatures()
{'cpu0_thermal': [shwtemp(label='', current=44.557, high=90.0, critical=90.0)], 'gpu0_thermal': [shwtemp(label='', current=43.972, high=None, critical=None)], 'gpu1_thermal': [shwtemp(label='', current=44.206, high=None, critical=None)], 'axp813_adc': [shwtemp(label='', current=29.7, high=None, critical=None)]}
```
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @ktaragorn,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

ktaragorn added a commit to ktaragorn/dotfiles that referenced this pull request Dec 30, 2021
Unlock smartIR, need latest version to run in new version
(https://community.home-assistant.io/t/configuration-component-error-not-found/313577/4)

Add ::1 to trusted proxies, suddenly we are using ipv6?
Yet another remaining Archive reference
Enable temperature but still doesnt work. have open PR for it,
home-assistant/core#63111
@ktaragorn
Copy link
Copy Markdown
Contributor Author

ktaragorn commented Dec 30, 2021

wonder if it makes sense to add an optional arg that can be configured with a label, to unblock people a bit faster?
Or to match for .*cpu.* to catch more permutations..

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ktaragorn 👍

@frenck frenck added this to the 2021.12.8 milestone Jan 2, 2022
@frenck frenck merged commit bf1f8f4 into home-assistant:dev Jan 2, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants