Skip to content

Ignore serial number "blank" from NUT#63066

Merged
frenck merged 1 commit into
home-assistant:devfrom
ollo69:nut-blank-serial
Dec 30, 2021
Merged

Ignore serial number "blank" from NUT#63066
frenck merged 1 commit into
home-assistant:devfrom
ollo69:nut-blank-serial

Conversation

@ollo69
Copy link
Copy Markdown
Contributor

@ollo69 ollo69 commented Dec 30, 2021

Proposed change

Some UPS model return the string "blank" as serial number. This fix is to ignore this value (as already done for the string "unknown") to avoid duplicated unique_id.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (nut) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ollo69 👍

@frenck frenck merged commit 7d1de80 into home-assistant:dev Dec 30, 2021
@ollo69 ollo69 deleted the nut-blank-serial branch December 30, 2021 09:27
@bdraco bdraco added this to the 2021.12.8 milestone Dec 30, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network UPS Tools (NUT) Device Conflict

5 participants