Skip to content

Fix reporting correct colormode for 3rd party Hue lights#63015

Merged
frenck merged 2 commits into
home-assistant:devfrom
marcelveldt:hue-fix-colormode
Dec 29, 2021
Merged

Fix reporting correct colormode for 3rd party Hue lights#63015
frenck merged 2 commits into
home-assistant:devfrom
marcelveldt:hue-fix-colormode

Conversation

@marcelveldt

@marcelveldt marcelveldt commented Dec 29, 2021

Copy link
Copy Markdown
Member

Proposed change

(some) Non-Official Hue lights do not report the current colormode correctly.
This workaround that by comparing the colors so the correct colormode will be shown in HA for both Official and 3rd party bulbs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant

Copy link
Copy Markdown

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcelveldt 👍

@frenck frenck modified the milestones: 2021.12.7, 2021.12.8 Dec 29, 2021
@frenck frenck merged commit 1547a04 into home-assistant:dev Dec 29, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Color mode for 3rd party lights in Hue integration Philips hue ligths color_temp state gone

4 participants