Fix mqtt reloading and rework tests#62950
Merged
emontnemery merged 3 commits intohome-assistant:devfrom Jan 3, 2022
Merged
Conversation
|
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
emontnemery
reviewed
Jan 3, 2022
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
Looks good, can be merged when the merge conflict is solved 👍
ec30e93 to
34d0fc8
Compare
emontnemery
approved these changes
Jan 3, 2022
jeeftor
pushed a commit
to jeeftor/core
that referenced
this pull request
Jan 4, 2022
* Improve mqtt reloading/tests and fix issues * Cleanup fixture for reloading test * isort and black remove replaced test_reloadable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix reloading issues for MQTT
buttonandselectplatform, and add tests for reloading on all supported platforms.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: