Skip to content

Fix mqtt reloading and rework tests#62950

Merged
emontnemery merged 3 commits intohome-assistant:devfrom
jbouwh:mqtt-reloading-stability
Jan 3, 2022
Merged

Fix mqtt reloading and rework tests#62950
emontnemery merged 3 commits intohome-assistant:devfrom
jbouwh:mqtt-reloading-stability

Conversation

@jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Dec 28, 2021

Proposed change

Fix reloading issues for MQTT button and select platform, and add tests for reloading on all supported platforms.

Reloading support was initiated for MQTT with #39531. Tests were only added for the light platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jbouwh jbouwh changed the title Improve mqtt reloading/tests and fix issues Fix mqtt reloading and rework tests Dec 29, 2021
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can be merged when the merge conflict is solved 👍

@jbouwh jbouwh force-pushed the mqtt-reloading-stability branch from ec30e93 to 34d0fc8 Compare January 3, 2022 08:36
@emontnemery emontnemery merged commit 061ce0c into home-assistant:dev Jan 3, 2022
@jbouwh jbouwh deleted the mqtt-reloading-stability branch January 3, 2022 19:20
jeeftor pushed a commit to jeeftor/core that referenced this pull request Jan 4, 2022
* Improve mqtt reloading/tests and fix issues

* Cleanup fixture for reloading test

* isort and black remove replaced test_reloadable
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server Controls -> YAML config reloading -> Manually configured MQTT entities does not work for new Button entities

3 participants