Skip to content

Use lock in Camera.create_stream#62757

Merged
uvjustin merged 1 commit intohome-assistant:devfrom
uvjustin:fix-modify-camera-stream
Dec 24, 2021
Merged

Use lock in Camera.create_stream#62757
uvjustin merged 1 commit intohome-assistant:devfrom
uvjustin:fix-modify-camera-stream

Conversation

@uvjustin
Copy link
Copy Markdown
Contributor

Use lock in Camera.create_stream
Rename create_stream to async_create_stream in Camera
Rename get_image to async_get_image in Stream
Rename get_image to async_get_image in KeyFrameConverter

Proposed change

During the development of #62611, we realized that there are some quick and easy changes to make in stream and camera that are better suited as a separate PR. The changes in this PR are listed above.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Rename Camera.create_stream Camera.async_create_stream
Rename get_image to async_get_image in KeyFrameConverter
@probot-home-assistant
Copy link
Copy Markdown

Hey there @hunterjm, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@uvjustin uvjustin merged commit 9dbba6b into home-assistant:dev Dec 24, 2021
@uvjustin uvjustin deleted the fix-modify-camera-stream branch December 24, 2021 20:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants