Skip to content

CI: Use wheel to install base requirements#62743

Merged
cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p:ci-wheel
Dec 24, 2021
Merged

CI: Use wheel to install base requirements#62743
cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p:ci-wheel

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Dec 24, 2021

Proposed change

Noticed that the prepare-base job wasn't using wheel to build build packages.

Using legacy 'setup.py install' for python-slugify, since package 'wheel' is not installed.
...

We already install wheel for the prepare-tests job, so it does make sense to do the same for prepare-base.

pip install -U "pip<20.3" setuptools wheel
pip install -r requirements_all.txt
pip install -r requirements_test.txt
pip install -e .

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Dec 24, 2021
@cdce8p cdce8p merged commit 6eb31de into home-assistant:dev Dec 24, 2021
@cdce8p cdce8p deleted the ci-wheel branch December 24, 2021 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants