Skip to content

Bump roombapy to 1.6.4#62741

Merged
bdraco merged 3 commits intohome-assistant:devfrom
freekode:patch-1
Dec 24, 2021
Merged

Bump roombapy to 1.6.4#62741
bdraco merged 3 commits intohome-assistant:devfrom
freekode:patch-1

Conversation

@freekode
Copy link
Copy Markdown
Contributor

@freekode freekode commented Dec 24, 2021

Breaking change

Proposed change

Update roombapy, with fixed version.
Changelog pschmitt/roombapy@1.6.4...1.6.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pschmitt, @cyr-ius, @shenxn, mind taking a look at this pull request as it has been labeled with an integration (roomba) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dgomes
Copy link
Copy Markdown
Contributor

dgomes commented Dec 24, 2021

Please add a comment with changes in the upstream library

@freekode freekode marked this pull request as ready for review December 24, 2021 14:13
@bdraco bdraco self-requested a review December 24, 2021 18:26
@bdraco bdraco added this to the 2021.12.6 milestone Dec 24, 2021
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. Thanks 👍

@bdraco bdraco merged commit 64d1a73 into home-assistant:dev Dec 24, 2021
@freekode freekode deleted the patch-1 branch December 25, 2021 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roomba connection error on startup ...

5 participants