Add number entity to Overkiz integration#62732
Conversation
|
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Also, I would have created a separate PR for the cleanup of |
I will remove the cleanup and address it in a seperate PR, together with your other comments! 👍🏻 |
This reverts commit 94ee9bf.
Remember to create the cleanup PR... |
| hass: HomeAssistant, | ||
| entry: ConfigEntry, | ||
| async_add_entities: AddEntitiesCallback, | ||
| ): |
There was a problem hiding this comment.
Missing return value typing.
) -> None:| if state := self.device.states.get(self.entity_description.key): | ||
| return state.value | ||
|
|
||
| return 0 |
There was a problem hiding this comment.
Why do we default to 0 instead of None?
5 participants
Proposed change
Adds number entity to Overkiz platform, mainly for setting configuration parameters like my position.
This PR will also address a late review, with a small improvement for all platforms sharing the same
asyn_setup_entrylogic.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: