Skip to content

Add missing __init__.py to overkiz tests#62727

Merged
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:overkiz_init
Dec 24, 2021
Merged

Add missing __init__.py to overkiz tests#62727
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:overkiz_init

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 24, 2021

Proposed change

Add missing __init__.py to overkiz tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco merged commit 690b5a9 into home-assistant:dev Dec 24, 2021
@bdraco bdraco deleted the overkiz_init branch December 24, 2021 08:55
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 24, 2021

Thanks. Curious why it didn't fail on the initial merge 🤷‍♂️

@epenet
Copy link
Copy Markdown
Contributor

epenet commented Dec 24, 2021

Due to concurrency the tests were never run on dev on the initial merge, and then it was hidden by the flake8 issue which also prevented to the tests from running.
I agree that we need to understand why it didn't fail on the initial PR... or we are likely to get caught by it again.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 24, 2021

I think the missing __init__.py confused the __pycache__ generation so it took more than one set of integration tests to run at the same time to trigger the condition.

Likely ok on a single run, but fails on a multi-integration run.

@iMicknl
Copy link
Copy Markdown
Member

iMicknl commented Dec 24, 2021

Thanks for fixing this and apologies for breaking core tests! Could it be that I didn't face this locally since I did run the tests mainly using pytest tests/components/overkiz? It never failed on missing init.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 24, 2021

It only failed on a full test run. It's a new quirk in the split CI that we are going to have to watch for manually for the time being

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants