Add button entity to Overkiz integration#62719
Conversation
|
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
| if ( | ||
| device.widget not in IGNORED_OVERKIZ_DEVICES | ||
| and device.ui_class not in IGNORED_OVERKIZ_DEVICES | ||
| ): |
There was a problem hiding this comment.
If you reverse the condition and continue, you can save some indent
There was a problem hiding this comment.
Will have a look tomorrow 👍🏼. And fix that for all other entities as well.
(or I can do it in the another PR which has the same base)
There was a problem hiding this comment.
Since its going to be the same for the existing platforms that are already merged, I'll go ahead and merge this now, and it can be adjusted in the next PR since its not a material change anyways.
| hass: HomeAssistant, | ||
| entry: ConfigEntry, | ||
| async_add_entities: AddEntitiesCallback, | ||
| ): |
There was a problem hiding this comment.
Missing return value typing.
4 participants
Proposed change
Adds a button entity to Overkiz integration. Mainly used to add the 'my position' button, which was a service before. Adds identify features as well which can be useful for diagnostic purposes.
(please note that Somfy messed up and they switched two commands, thus we did switch them as well until they fix it in a new firmware/web update).
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: