Skip to content

Add lqi and rssi sensors back to ZHA#62716

Merged
Adminiuga merged 10 commits intohome-assistant:devfrom
dmulcahey:dm/zha-lqi-rssi
Dec 24, 2021
Merged

Add lqi and rssi sensors back to ZHA#62716
Adminiuga merged 10 commits intohome-assistant:devfrom
dmulcahey:dm/zha-lqi-rssi

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Dec 23, 2021

Breaking change

Proposed change

Add lqi and rssi diagnostic sensors to ZHA.

## TODO
- [x] Update device list to add the new sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dmulcahey dmulcahey mentioned this pull request Dec 23, 2021
26 tasks
@dmulcahey dmulcahey marked this pull request as ready for review December 24, 2021 00:57
@dmulcahey dmulcahey requested a review from Adminiuga as a code owner December 24, 2021 00:57
Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to merge once the test pass

Copy link
Copy Markdown
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Adminiuga Adminiuga merged commit 0062676 into home-assistant:dev Dec 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
@dmulcahey dmulcahey deleted the dm/zha-lqi-rssi branch November 11, 2022 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants