Add lock entity to Overkiz integration#62713
Merged
bdraco merged 5 commits intohome-assistant:devfrom Dec 23, 2021
Merged
Conversation
|
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
Member
|
Please add uncovered files to |
bdraco
reviewed
Dec 23, 2021
22 tasks
epenet
reviewed
Dec 23, 2021
bdraco
approved these changes
Dec 23, 2021
| hass: HomeAssistant, | ||
| entry: ConfigEntry, | ||
| async_add_entities: AddEntitiesCallback, | ||
| ): |
Member
There was a problem hiding this comment.
Missing return value typing.
Member
There was a problem hiding this comment.
diff --git a/.strict-typing b/.strict-typing
index 8f7ca3311c..fa2addb86b 100644
--- a/.strict-typing
+++ b/.strict-typing
@@ -101,6 +101,7 @@ homeassistant.components.number.*
homeassistant.components.onewire.*
homeassistant.components.open_meteo.*
homeassistant.components.openuv.*
+homeassistant.components.overkiz.*
homeassistant.components.persistent_notification.*
homeassistant.components.pi_hole.*
homeassistant.components.proximity.*
and run python3 -m script.hassfest, you will get some additional feedback from mypy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for lock entities and the platform base that is required for all other entities.
Apparently, I forgot to build translations in previous PR, thus I added that in this one as well.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: