Skip to content

Fix HomeKit sensor update check#62705

Merged
bdraco merged 3 commits intohome-assistant:devfrom
br3sc4:fix-homekit-sensor-update
Dec 24, 2021
Merged

Fix HomeKit sensor update check#62705
bdraco merged 3 commits intohome-assistant:devfrom
br3sc4:fix-homekit-sensor-update

Conversation

@br3sc4
Copy link
Copy Markdown
Contributor

@br3sc4 br3sc4 commented Dec 23, 2021

Breaking change

Proposed change

This PR fixes a bug in HomeKit integration: when a sensor reads 0, the integration doesn't call the update callback.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@br3sc4 br3sc4 requested a review from bdraco as a code owner December 23, 2021 21:03
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @br3sc4,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 23, 2021

Thanks. Please add a test that sets the state to 0 with hass.states. There should be a few you can copy

@br3sc4
Copy link
Copy Markdown
Contributor Author

br3sc4 commented Dec 23, 2021

I added the tests, I hope to make it the right way.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 23, 2021

The hap spec enforces a minimum of 0.0001 for the light level so when you set 0 you will get 0.0001. This is expected

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #62705 (comment)

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@bdraco bdraco merged commit 0da710c into home-assistant:dev Dec 24, 2021
@br3sc4
Copy link
Copy Markdown
Contributor Author

br3sc4 commented Dec 24, 2021

You're welcome 😉

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Light sensor not showing value 0 in HomeKit

4 participants