Skip to content

Update no_ip URL#62477

Merged
frenck merged 1 commit into
devfrom
noip-url
Jan 4, 2022
Merged

Update no_ip URL#62477
frenck merged 1 commit into
devfrom
noip-url

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Dec 21, 2021

Breaking change

Proposed change

Update URl (see https://www.noip.com/integrate/request)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 21, 2021

This integration should be adjusted to have a package on PyPi.

@MartinHjelmare MartinHjelmare changed the title Update URL Update no_ip URL Dec 21, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 4, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this in, since it is a really simple bug fix.
Further changes to this integration would definitely need some refactoring.

@frenck frenck added this to the 2021.12.8 milestone Jan 4, 2022
@frenck frenck merged commit e2f7a58 into dev Jan 4, 2022
@frenck frenck deleted the noip-url branch January 4, 2022 12:42
jeeftor pushed a commit to jeeftor/core that referenced this pull request Jan 4, 2022
balloob pushed a commit that referenced this pull request Jan 4, 2022
@balloob balloob mentioned this pull request Jan 4, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed integration: no_ip small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NO-IP.COM component doesn't work

4 participants