Invalidate CI cache when bumping dependencies#62394
Merged
Conversation
ludeeus
approved these changes
Dec 20, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
MartinHjelmare
approved these changes
Dec 20, 2021
22 tasks
balloob
pushed a commit
that referenced
this pull request
Dec 20, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Second attempt to fix our CI issues, the first attempt in #62383.
While #62383 worked for a couple of hours, we are already experiencing the same issue again. At the moment of writing, it seems that only PRs bumping a dependency are affected.
This PR changes the behavior of the venv a little bit. Instead of restoring an venv and upgrading the package, it rebuilds the full venv now.
A performance drop in the CI will be noticeable, as it takes 13-15 minutes to set up a fresh venv; However, this would only affect PRs and merged to dev that includes dependency bumps.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: