Skip to content

Invalidate CI cache when bumping dependencies#62394

Merged
frenck merged 2 commits intodevfrom
frenck-2021-3308
Dec 20, 2021
Merged

Invalidate CI cache when bumping dependencies#62394
frenck merged 2 commits intodevfrom
frenck-2021-3308

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Dec 20, 2021

Proposed change

Second attempt to fix our CI issues, the first attempt in #62383.

While #62383 worked for a couple of hours, we are already experiencing the same issue again. At the moment of writing, it seems that only PRs bumping a dependency are affected.

This PR changes the behavior of the venv a little bit. Instead of restoring an venv and upgrading the package, it rebuilds the full venv now.

A performance drop in the CI will be noticeable, as it takes 13-15 minutes to set up a fresh venv; However, this would only affect PRs and merged to dev that includes dependency bumps.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Dec 20, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@frenck frenck merged commit f14f0f9 into dev Dec 20, 2021
@frenck frenck deleted the frenck-2021-3308 branch December 20, 2021 15:22
@balloob balloob added this to the 2021.12.4 milestone Dec 20, 2021
balloob pushed a commit that referenced this pull request Dec 20, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Dec 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants