Skip to content

Use new enums in solax #62376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 2 commits into from
Dec 20, 2021
Merged

Use new enums in solax #62376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f306888
Use new enums in solax
epenet Dec 20, 2021
290b119
Merge branch 'home-assistant:dev' into enum-solax
epenet Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 15 additions & 25 deletions homeassistant/components/solax/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,11 @@

from homeassistant.components.sensor import (
PLATFORM_SCHEMA,
STATE_CLASS_MEASUREMENT,
STATE_CLASS_TOTAL_INCREASING,
SensorDeviceClass,
SensorEntity,
SensorStateClass,
)
from homeassistant.const import (
CONF_IP_ADDRESS,
CONF_PORT,
DEVICE_CLASS_BATTERY,
DEVICE_CLASS_CURRENT,
DEVICE_CLASS_ENERGY,
DEVICE_CLASS_POWER,
DEVICE_CLASS_TEMPERATURE,
DEVICE_CLASS_VOLTAGE,
TEMP_CELSIUS,
)
from homeassistant.const import CONF_IP_ADDRESS, CONF_PORT, TEMP_CELSIUS
from homeassistant.exceptions import PlatformNotReady
import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.event import async_track_time_interval
Expand Down Expand Up @@ -51,24 +41,24 @@ async def async_setup_platform(hass, config, async_add_entities, discovery_info=
for sensor, (idx, unit) in api.inverter.sensor_map().items():
device_class = state_class = None
if unit == "C":
device_class = DEVICE_CLASS_TEMPERATURE
state_class = STATE_CLASS_MEASUREMENT
device_class = SensorDeviceClass.TEMPERATURE
state_class = SensorStateClass.MEASUREMENT
unit = TEMP_CELSIUS
elif unit == "kWh":
device_class = DEVICE_CLASS_ENERGY
state_class = STATE_CLASS_TOTAL_INCREASING
device_class = SensorDeviceClass.ENERGY
state_class = SensorStateClass.TOTAL_INCREASING
elif unit == "V":
device_class = DEVICE_CLASS_VOLTAGE
state_class = STATE_CLASS_MEASUREMENT
device_class = SensorDeviceClass.VOLTAGE
state_class = SensorStateClass.MEASUREMENT
elif unit == "A":
device_class = DEVICE_CLASS_CURRENT
state_class = STATE_CLASS_MEASUREMENT
device_class = SensorDeviceClass.CURRENT
state_class = SensorStateClass.MEASUREMENT
elif unit == "W":
device_class = DEVICE_CLASS_POWER
state_class = STATE_CLASS_MEASUREMENT
device_class = SensorDeviceClass.POWER
state_class = SensorStateClass.MEASUREMENT
elif unit == "%":
device_class = DEVICE_CLASS_BATTERY
state_class = STATE_CLASS_MEASUREMENT
device_class = SensorDeviceClass.BATTERY
state_class = SensorStateClass.MEASUREMENT
uid = f"{serial}-{idx}"
devices.append(Inverter(uid, serial, sensor, unit, state_class, device_class))
endpoint.sensors = devices
Expand Down