Skip to content

Remove deprecated yaml config from dlna_dmr#62344

Merged
frenck merged 1 commit intohome-assistant:devfrom
tkdrob:dlna_dmr_yaml
Dec 20, 2021
Merged

Remove deprecated yaml config from dlna_dmr#62344
frenck merged 1 commit intohome-assistant:devfrom
tkdrob:dlna_dmr_yaml

Conversation

@tkdrob
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob commented Dec 19, 2021

Breaking change

The previously deprecated YAML configuration of the DLNA DMR integration has been removed.

DLNA DMR is now configured via the UI, any existing YAML configuration has been imported in previous releases and can now be safely removed from your YAML configuration files.

Proposed change

Remove deprecated yaml config from dlna_dmr

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @StevenLooman, @chishm, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

@frenck frenck merged commit e689afc into home-assistant:dev Dec 20, 2021
@chishm
Copy link
Copy Markdown
Contributor

chishm commented Dec 20, 2021

Ah, I didn't get to this in time. There was one small bit in config_flow.py:DlnaDmrFlowHandler.async_step_ssdp that can be removed too, the loop below the comment "Abort if a migration flow for the device's location is in progress".

@tkdrob tkdrob deleted the dlna_dmr_yaml branch December 21, 2021 07:28
@tkdrob tkdrob mentioned this pull request Dec 21, 2021
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants