Skip to content

Add wemo config_flow test to get 100% coverage#62158

Merged
bdraco merged 4 commits into
home-assistant:devfrom
esev:wemo_config_flow_test
Dec 19, 2021
Merged

Add wemo config_flow test to get 100% coverage#62158
bdraco merged 4 commits into
home-assistant:devfrom
esev:wemo_config_flow_test

Conversation

@esev
Copy link
Copy Markdown
Contributor

@esev esev commented Dec 17, 2021

Proposed change

Improving test coverage of wemo/config_flow.py.

Doing this prior to making a config_flow change in #62157.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread tests/components/wemo/test_config_flow.py Outdated
@bdraco bdraco merged commit 8d6763e into home-assistant:dev Dec 19, 2021
@esev esev deleted the wemo_config_flow_test branch December 19, 2021 09:14
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants