Skip to content

sensor.speedtest: provide a default icon#6207

Merged
fabaff merged 1 commit into
home-assistant:devfrom
molobrakos:speedtest
Feb 24, 2017
Merged

sensor.speedtest: provide a default icon#6207
fabaff merged 1 commit into
home-assistant:devfrom
molobrakos:speedtest

Conversation

@molobrakos
Copy link
Copy Markdown
Contributor

Description:

provide a default icon

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@molobrakos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nkgilley, @fabaff and @balloob to be potential reviewers.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 8aa3124 into home-assistant:dev Feb 24, 2017
@molobrakos molobrakos deleted the speedtest branch February 24, 2017 22:00
@home-assistant home-assistant locked and limited conversation to collaborators Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants