Skip to content

Fix reporting on bad login#6201

Merged
balloob merged 1 commit into
devfrom
bugfix/websocket-report-bad-login
Feb 25, 2017
Merged

Fix reporting on bad login#6201
balloob merged 1 commit into
devfrom
bugfix/websocket-report-bad-login

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 24, 2017

Description:

Wrong authentication at websocket connections will now trigger the same flow as wrong auth for HTTP endpoints.

Related issue (if applicable): fixes #6093

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kellerza, @molobrakos and @armills to be potential reviewers.

Copy link
Copy Markdown
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are fast ⚡

@balloob balloob merged commit d6818c7 into dev Feb 25, 2017
@balloob balloob deleted the bugfix/websocket-report-bad-login branch February 25, 2017 00:34
balloob added a commit that referenced this pull request Feb 25, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no more logging of bad logins in 0.38.3

4 participants