Random test fixes#6195
Merged
Merged
Conversation
|
|
||
| CONFIG_SCHEMA = vol.Schema({ | ||
| DOMAIN: vol.Schema({ | ||
| vol.Required(DOMAIN): vol.Schema({ |
Member
There was a problem hiding this comment.
Is this a new standard? I haven't seen any other component that does it like this.
Member
Author
There was a problem hiding this comment.
From my testing, it looked like not having this meant that not having sleepiq in your config was ok too (but it shouldn't, username is required)
Member
There was a problem hiding this comment.
How could the component be setup without the domain in the config? From another component?
Member
Author
There was a problem hiding this comment.
All the platforms depend on the main component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
While fixing some recorder stuff ran into these issues