Skip to content

Fix "vevent" KeyError in caldav component #61718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 3 commits into from
Dec 17, 2021
Merged

Fix "vevent" KeyError in caldav component #61718

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8247260
Fix "vevent" KeyError in caldav component
jkuettner Dec 13, 2021
fd5ee4a
log skipped events with missing 'vevent' property
jkuettner Dec 15, 2021
82401b7
Fix "vevent" KeyError in caldav update component
jkuettner Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions homeassistant/components/caldav/calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ async def async_get_events(self, hass, start_date, end_date):
)
event_list = []
for event in vevent_list:
if not hasattr(event.instance, "vevent"):
_LOGGER.warning("Skipped event with missing 'vevent' property")
continue
vevent = event.instance.vevent
if not self.is_matching(vevent, self.search):
continue
Expand Down Expand Up @@ -198,6 +201,9 @@ def update(self):
# and they would not be properly parsed using their original start/end dates.
new_events = []
for event in results:
if not hasattr(event.instance, "vevent"):
_LOGGER.warning("Skipped event with missing 'vevent' property")
continue
vevent = event.instance.vevent
for start_dt in vevent.getrruleset() or []:
_start_of_today = start_of_today
Expand Down