Skip to content

Fix Tuya vacuum display battery level#61643

Merged
frenck merged 3 commits into
home-assistant:devfrom
dougiteixeira:dev-tuya-vaccum-battery
Jan 2, 2022
Merged

Fix Tuya vacuum display battery level#61643
frenck merged 3 commits into
home-assistant:devfrom
dougiteixeira:dev-tuya-vaccum-battery

Conversation

@dougiteixeira
Copy link
Copy Markdown
Contributor

@dougiteixeira dougiteixeira commented Dec 13, 2021

Proposed change

Fixes issue of not loading vacuum entity battery level attribute reported in #61642.

image
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @tuya, @zlinoliver, @METISU, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dougiteixeira dougiteixeira changed the title Tuya vacuum diplay battery level Tuya vacuum display battery level Dec 13, 2021
Comment thread homeassistant/components/tuya/vacuum.py Outdated
@dougiteixeira dougiteixeira requested a review from frenck January 2, 2022 15:11
Comment thread homeassistant/components/tuya/vacuum.py Outdated
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@dougiteixeira dougiteixeira requested a review from frenck January 2, 2022 19:27
@frenck frenck added this to the 2021.12.8 milestone Jan 2, 2022
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dougiteixeira 👍

@frenck frenck changed the title Tuya vacuum display battery level Fix Tuya vacuum display battery level Jan 2, 2022
@frenck frenck merged commit 66c2259 into home-assistant:dev Jan 2, 2022
@dougiteixeira dougiteixeira deleted the dev-tuya-vaccum-battery branch January 3, 2022 00:32
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tuya vacuum does not display battery status

4 participants