Skip to content

Update version of iZone library to add some bug fixes#61548

Merged
balloob merged 3 commits intohome-assistant:devfrom
Swamp-Ig:izone-bugfix
Dec 20, 2021
Merged

Update version of iZone library to add some bug fixes#61548
balloob merged 3 commits intohome-assistant:devfrom
Swamp-Ig:izone-bugfix

Conversation

@Swamp-Ig
Copy link
Copy Markdown
Contributor

@Swamp-Ig Swamp-Ig commented Dec 12, 2021

Proposed change

Update to newest version of iZone library. This fixes some issues with returned message handling and fixes some errors that were crashing the library update loop, plus cleans up the messages.

The new library version also includes power monitoring, but this is not active in HA yet.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Swamp-Ig Swamp-Ig marked this pull request as ready for review December 17, 2021 14:00
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 19, 2021

Was this categorized incorrect as push but is really polling?

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 19, 2021

Was this categorized incorrect as push but is really polling?

If so we need to fix it here as well https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/izone.markdown

@Swamp-Ig
Copy link
Copy Markdown
Contributor Author

Was this categorized incorrect as push but is really polling?

Yeh that's correct. The device was pretending to push, but actually it just just sent out alerts to re-poll on a fixed period. The newer version of the device doesn't even do that.

@Swamp-Ig
Copy link
Copy Markdown
Contributor Author

Was this categorized incorrect as push but is really polling?

If so we need to fix it here as well https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/izone.markdown

#20753

@balloob balloob merged commit 2d049e9 into home-assistant:dev Dec 20, 2021

# homeassistant.components.izone
python-izone==1.1.8
python-izone==1.2.3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find a github release or tag for version 1.2.3. Is it possible to add that so we can see the changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeh sure. I think I forgot to push the tag. Will do this when I get home. It's the head version anyhow.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2021
@Swamp-Ig
Copy link
Copy Markdown
Contributor Author

Swamp-Ig commented Jan 1, 2022

@MartinHjelmare could this please be included in the next patch release, rather than the next major? It's a bug-fix really.

@bdraco bdraco added this to the 2021.12.8 milestone Jan 1, 2022
@Swamp-Ig Swamp-Ig deleted the izone-bugfix branch August 24, 2022 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants