Add identify buttons to ZHA devices#61495
Merged
Adminiuga merged 7 commits intohome-assistant:devfrom Dec 23, 2021
Merged
Conversation
|
Hey there @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( |
ae5ae39 to
05bbfdf
Compare
9128029 to
fe2037a
Compare
Adminiuga
approved these changes
Dec 19, 2021
Contributor
Adminiuga
left a comment
There was a problem hiding this comment.
LGTM. Looks like need to add some more coverage :)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds support for the button platform to ZHA and leverages this to add identify buttons to ZHA devices.
Things left to be done:
- [ ] add stop on match group once this PR is merged: Refactor ZHA entity matching process #60063So the referenced PR was merged and I think we still need to make another change to discovery. With the way things work currently we will get an identify button per device endpoint. We need to add a way to prevent discovery from spanning device endpoints. We may also want to favor a particular ZCL profile ex: ZHA vs the mfg profile on most Centralite devices.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
home-assistant/home-assistant.io#20845
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: