Support Plex resuming and playback offset#61468
Merged
bdraco merged 1 commit intohome-assistant:devfrom Dec 20, 2021
Merged
Conversation
Member
|
This looks fine. The service taking a json string seems a bit odd though... I don't know the history here, but was there a reason something like this can't work? |
bdraco
approved these changes
Dec 19, 2021
Contributor
Author
|
Legacy conventions. Could possibly be refactored to accept both ways but it is probably better to come up with a new convention to handle this more cleanly in all media players. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Support two new parameters in the
media_content_idpayload for Plexmedia_player.play_mediaservice calls:resume: Resume playback from the last known positionoffset: Begin playback at X seconds from the beginningIf both are included,
offsetwill take precedence.Examples:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: