Handle None values in weather entity forecast#61467
Merged
frenck merged 3 commits intohome-assistant:devfrom Dec 16, 2021
Merged
Handle None values in weather entity forecast#61467frenck merged 3 commits intohome-assistant:devfrom
frenck merged 3 commits intohome-assistant:devfrom
Conversation
|
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( |
22 tasks
frenck
reviewed
Dec 16, 2021
frenck
approved these changes
Dec 16, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
LGTM, this also matches the developer docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I've realized that some of the weather components pass in
Nonevalues to forecast attributes. This currently causes the unit conversions to fail if the units are configured, since the unit conversion methods cannot handleNone.To be clear, nothing is currently failing because of this issue. However, I am running into this problem when fixing my PRs to update the weather unit conversion in components.
I figure it's easier to handle
Nonevalues inside the weather entity rather than in every component.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: