Skip to content

Fix gtfs timestamp sensor#61204

Merged
allenporter merged 1 commit into
devfrom
gtfs
Dec 8, 2021
Merged

Fix gtfs timestamp sensor#61204
allenporter merged 1 commit into
devfrom
gtfs

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Dec 8, 2021

Breaking change

Proposed change

Fix gtfs timestamp sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2021.12.0 milestone Dec 8, 2021
@probot-home-assistant probot-home-assistant Bot added bugfix integration: gtfs small-pr PRs with less than 30 lines. labels Dec 8, 2021
@allenporter allenporter merged commit e011073 into dev Dec 8, 2021
@allenporter allenporter deleted the gtfs branch December 8, 2021 06:49
self._state = dt_util.as_utc(
self._departure["departure_time"]
).isoformat()
self._state = dt_util.as_utc(self._departure["departure_time"])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UTC conversion is no longer needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balloob added a commit that referenced this pull request Dec 8, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants