Skip to content

Add network support to flux_led discovery [test to see why #61132 is failing the CI]#61188

Closed
bdraco wants to merge 4 commits intohome-assistant:devfrom
bdraco:flux_led_network_discovery_attempt_2
Closed

Add network support to flux_led discovery [test to see why #61132 is failing the CI]#61188
bdraco wants to merge 4 commits intohome-assistant:devfrom
bdraco:flux_led_network_discovery_attempt_2

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 7, 2021

Proposed change

Add network support to flux_led discovery

The scanner is now aware of multiple network interfaces

Bump flux_led to 0.26.x as the lib now supports concurrent discovery which allows the locks to be removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as draft December 7, 2021 21:09
@bdraco bdraco changed the title Add network support to flux_led discovery Add network support to flux_led discovery [test to see why #61132 is failing the CI] Dec 7, 2021
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 7, 2021

#61132 seems ok now

@bdraco bdraco closed this Dec 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading to 2021.11.1 - getting [flux_led.aioscanner] LEDENETDiscovery error: [WinError 10022] An invalid argument was supplied

2 participants