Migrate binary sensor device classes to StrEnum#60651
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @eavanvalkenburg, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @scop, mind taking a look at this pull request as it has been labeled with an integration ( |
| class UpCloudBinarySensor(UpCloudServerEntity, BinarySensorEntity): | ||
| """Representation of an UpCloud server sensor.""" | ||
|
|
||
| _attr_device_class = BinarySensorDeviceClass.POWER |
There was a problem hiding this comment.
I don't know this integration, is this correct?
There was a problem hiding this comment.
Previously it used a hard coded string in its parent class to "power" for all iets platforms...
So this makes it specific on this platform to fix that (and make mypy happy as it now has catches this bug)
Breaking change
This PR deprecates the use of the
DEVICE_CLASS_*constants andDEVICE_CLASSESconstant forbinary_sensorentities. Use theBinarySensorDeviceClassenum instead.Proposed change
Replaces the device class constants of the binary sensor platform with a StrEnum.
The old CONST is currently still accepted and working (backward compatible). This gives core and custom integration time to adjust.
At this point, I've not set a deprecation period as it is hard to indicate how long this would take.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: