Fix climacell hourly and nowcast forecasts#60454
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Nov 28, 2021
Merged
Fix climacell hourly and nowcast forecasts#60454MartinHjelmare merged 1 commit intohome-assistant:devfrom
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Conversation
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Nov 27, 2021
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Nov 27, 2021
|
I patched the PR into my HA installation - works like a charm. Thanks for all your effort!!!!! |
avee87
approved these changes
Nov 27, 2021
MartinHjelmare
approved these changes
Nov 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As reported by a user, in the details/more info section for a weather entity, the UI shows the full date instead of the time for hourly and nowcast forecast types. This is because we are providing both a
tempandtemp_lowwhich doesn't make much sense in this instance because the timeframe is so short, plus the frontend code uses the presence oftemp_lowto determine whether this is daily data or something more frequent.Because this issue is specific to the frontend logic, there's nothing functional to test in the backend.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: