Skip to content

Fix climacell hourly and nowcast forecasts#60454

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
raman325:climacell_hourly
Nov 28, 2021
Merged

Fix climacell hourly and nowcast forecasts#60454
MartinHjelmare merged 1 commit intohome-assistant:devfrom
raman325:climacell_hourly

Conversation

@raman325
Copy link
Copy Markdown
Contributor

Proposed change

As reported by a user, in the details/more info section for a weather entity, the UI shows the full date instead of the time for hourly and nowcast forecast types. This is because we are providing both a temp and temp_low which doesn't make much sense in this instance because the timeframe is so short, plus the frontend code uses the presence of temp_low to determine whether this is daily data or something more frequent.

Because this issue is specific to the frontend logic, there's nothing functional to test in the backend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

raman325 added a commit to raman325/home-assistant that referenced this pull request Nov 27, 2021
raman325 added a commit to raman325/home-assistant that referenced this pull request Nov 27, 2021
@bigcookie
Copy link
Copy Markdown

I patched the PR into my HA installation - works like a charm. Thanks for all your effort!!!!!

@MartinHjelmare MartinHjelmare merged commit bae01ca into home-assistant:dev Nov 28, 2021
@raman325 raman325 deleted the climacell_hourly branch November 28, 2021 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Climacell integration not feeding date/time correctly to weather card for hourly forecasts

5 participants