Skip to content

Introduce SsdpServiceInfo for ssdp discovery#60284

Merged
bdraco merged 7 commits intohome-assistant:devfrom
epenet:SsdpServiceInfo
Nov 25, 2021
Merged

Introduce SsdpServiceInfo for ssdp discovery#60284
bdraco merged 7 commits intohome-assistant:devfrom
epenet:SsdpServiceInfo

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 24, 2021

Proposed change

Introduce new SsdpServiceInfo class as preliminary work for #59931.

Updated a single component (arcam_fmj) to show how it would work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @elupus, mind taking a look at this pull request as it has been labeled with an integration (arcam_fmj) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 24, 2021

cc @bdraco, @StevenLooman, @chishm

@epenet epenet mentioned this pull request Nov 24, 2021
22 tasks
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 24, 2021

Only failing due to code patch coverage :(

@bdraco bdraco requested a review from StevenLooman November 24, 2021 13:56
@bdraco bdraco merged commit 62bf42e into home-assistant:dev Nov 25, 2021
@chishm
Copy link
Copy Markdown
Contributor

chishm commented Nov 25, 2021 via email

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 25, 2021

It's too late for this PR, but the location header can be missing for ssdp:byebye messages.

@chishm, would these byebye message still trigger a discovery flow?
It seems all the tests have a location in so I think that would involve adding tests with ssdp:byebye messages.

@epenet epenet deleted the SsdpServiceInfo branch November 25, 2021 07:04
@chishm
Copy link
Copy Markdown
Contributor

chishm commented Nov 25, 2021

It's too late for this PR, but the location header can be missing for ssdp:byebye messages.

@chishm, would these byebye message still trigger a discovery flow? It seems all the tests have a location in so I think that would involve adding tests with ssdp:byebye messages.

The scanner.Scanner._ssdp_listener_callback method is very careful to not trigger config flows for ssdp:byebye messages (it doesn't really make sense to), so there's no trouble there. However, callbacks registered via ssdp.async_register_callback can expect to receive byebye messages. For example, dlna_dmr does this to know when a device is turned off.

I'll continue this discussion on #59931

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 25, 2021

Give me a minute I'm about to open a PR for this.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants