Skip to content

Update ssdp matching_domain constant#60283

Merged
bdraco merged 1 commit intohome-assistant:devfrom
epenet:ssdp-rename-variable
Nov 24, 2021
Merged

Update ssdp matching_domain constant#60283
bdraco merged 1 commit intohome-assistant:devfrom
epenet:ssdp-rename-variable

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 24, 2021

Breaking change

The value of ATTR_HA_MATCHING_DOMAINS constant has been updated to replace the hash (-) with underscore (_):
Old value: x-homeassistant-matching-domains
New value: x_homeassistant_matching_domains

Proposed change

As preliminary work for #59931, update the value of ATTR_HA_MATCHING_DOMAINS constant to be able to then create a corresponding x_homeassistant_matching_domains dataclass property.

This should not be a breaking change, as only dlna_dmr uses it, and dlna_dmr uses the constant not the string. It is marked as a breaking change just in case a custom component uses the value instead of the constant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 24, 2021

cc @bdraco, @StevenLooman, @chishm

@epenet epenet mentioned this pull request Nov 24, 2021
22 tasks
@bdraco bdraco merged commit d990fe1 into home-assistant:dev Nov 24, 2021
@epenet epenet deleted the ssdp-rename-variable branch November 24, 2021 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants