Update ZeroconfServiceInfo in tests (g-m)#60217
Conversation
|
Hey there @wonderslug, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @vangorra, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @swails, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @balloob, @frenck, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration ( |
Jc2k
left a comment
There was a problem hiding this comment.
I would have probably set port to something like 8080, but if None is a permitted value than i'm fine with this too. LGTM.
Proposed change
As preliminary work for #60206, ensure that all properties in
ZeroconfServiceInfoare initialised in testsType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: