Use dataclass for MqttServiceInfo

[epenet]

Breaking change

MQTT discovery now uses a dataclass instead of a dictionary object.
Access using __getitem__ will fail in version 2022.6.
Please use <cls>.<name> instead.

Proposed change

MQTT discovery now uses a dataclass instead of a dictionary object.
Access using __getitem__ will fail in version 2022.6.
Please use <cls>.<name> instead.

Linked to this comment in the architecture discussion home-assistant/architecture#662 (comment)

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[epenet]

I think it is ok to use WARNING (not DEBUG) straight away for usb as there is only one core component and the PRs for these are ready on my machine:

• tasmota

[emontnemery]

Yes, that's fine

[emontnemery]

Thanks, @epenet

[MartinHjelmare]

We need to update the infrastructure for flows, data_entry_flow etc, first before merging these.

[epenet]

@MartinHjelmare does this need reverting?

data_entry_flow.py should not require amends (the discovery steps are not called by the UI)

config_entries.py is ready for this:

core/homeassistant/config_entries.py

Lines 1383 to 1387 in 4aae088

	async def async_step_dhcp(
	self, discovery_info: DhcpServiceInfo
	) -> data_entry_flow.FlowResult:
	"""Handle a flow initialized by DHCP discovery."""
	return await self.async_step_discovery(cast(dict, discovery_info))

helpers/config_entry_flow.py is ready for this also:

core/homeassistant/helpers/config_entry_flow.py

Lines 86 to 93 in 4aae088

	async def async_step_dhcp(self, discovery_info: dhcp.DhcpServiceInfo) -> FlowResult:
	"""Handle a flow initialized by dhcp discovery."""
	if self._async_in_progress() or self._async_current_entries():
	return self.async_abort(reason="single_instance_allowed")
	await self.async_set_unique_id(self._domain)
	return await self.async_step_confirm()

Components can continue using discovery_info[ATTR]

[epenet]

I will add BaseServiceInfo inheritance in a new PR as soon as #60136 is merged