Fix missing mocking for SamsungTV tests#60181
Conversation
|
Hey there @escoand, mind taking a look at this pull request as it has been labeled with an integration ( |
|
There are still some slow tests in
|
|
There are still three tests taking a long time: |
| with patch( | ||
| "homeassistant.components.samsungtv.bridge.SamsungTVWSBridge.device_info", | ||
| return_value=MOCK_DEVICE_INFO, | ||
| ), patch("getmac.get_mac_address", return_value="aa:bb:cc:dd:ee:ff"): |
There was a problem hiding this comment.
We have this fixture already. We can use it and just change the return value in the test.
core/tests/components/samsungtv/conftest.py
Lines 117 to 121 in be94ce4
Proposed change
Add missing mocking to tests: from +200s to 15s
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: