Use ZeroconfServiceInfo in hue#59980
Merged
balloob merged 2 commits intohome-assistant:devfrom Nov 20, 2021
Merged
Conversation
probot-home-assistant
bot
added
code-quality
has-tests
integration: hue
small-pr
|
Hey there @balloob, @frenck, @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration ( |
epenet
commented
Nov 19, 2021
Comment on lines
+518
to
+521
| data=zeroconf.ZeroconfServiceInfo( | ||
| host="0.0.0.0", properties={"id": "aa:bb:cc:dd:ee:ff"} | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
Note: serial and manufacturerURL are not available in ZeroconfServiceInfo, and are not used by the config_flow. I think it must have been a bad copy/paste from ssdp discovery.
Member
There was a problem hiding this comment.
I think that is safe to assume indeed.
Contributor
Author
|
Waiting for #59986 to be merged |
epenet
force-pushed
the
hue-ZeroconfServiceInfo
branch
from
6d23bf1 to
4457c4a
Compare
Contributor
Author
|
Rebased now #59986 has been merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use
ZeroconfServiceInfo(and zeroconf constants) inhue.See home-assistant/architecture#662
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: