Skip to content

Remove duplicate UPnP info in ssdp#59960

Closed
epenet wants to merge 3 commits intohome-assistant:devfrom
epenet:ssdp-cleanup-discovery
Closed

Remove duplicate UPnP info in ssdp#59960
epenet wants to merge 3 commits intohome-assistant:devfrom
epenet:ssdp-cleanup-discovery

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 19, 2021

Breaking change

In HomeAssistant release TBC (PR #59931), UPnP discovery data was made available in discovery_info[ATTR_UPNP][xxx].
Access via discovery_info[xxx] was since deprecated and has now been removed.

Proposed change

As a follow-up to #59931, the duplicated UPnP discovery data is removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet changed the title Ssdp cleanup discovery Remove duplicate UPnP info in ssdp Nov 19, 2021
@epenet epenet mentioned this pull request Nov 19, 2021
22 tasks
@epenet epenet mentioned this pull request Nov 19, 2021
22 tasks
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 24, 2021

No longer needed.

@epenet epenet closed this Nov 24, 2021
@epenet epenet deleted the ssdp-cleanup-discovery branch November 24, 2021 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants