Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration entities to Tuya Vacuum (sd) #59906

Closed
wants to merge 4 commits into from
Closed

Add configuration entities to Tuya Vacuum (sd) #59906

wants to merge 4 commits into from

Conversation

cvroque
Copy link
Contributor

@cvroque cvroque commented Nov 18, 2021

Proposed change

Adds volume setting, dnd switch, voice switch, map resetting to supported robot vacuum (sd)
image

I've added these based on the official documentation and the devices below:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @tuya, @zlinoliver, @METISU, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cvroque cvroque closed this Nov 18, 2021
@cvroque cvroque deleted the vacuum-config_entities branch November 18, 2021 15:32
@alexdelprete
Copy link

Hi @cvroque, will you resubmit this? I was hoping something like this would be implemented for Tuya vacuum device: tuya/tuya-home-assistant#9

Right now I only have stop/start controls, no status entities.

@cvroque
Copy link
Contributor Author

cvroque commented Nov 18, 2021

Hi @cvroque, will you resubmit this? I was hoping something like this would be implemented for Tuya vacuum device: tuya/tuya-home-assistant#9

Right now I only have stop/start controls, no status entities.

Hello! Yes, I'll submit the PR again after further testing, but I'll recommend you to open an issue and add the device data that has been asked by Frenck in other Tuya Issues, as that would help us figuring out what your device needs.

@alexdelprete
Copy link

I'll recommend you to open an issue and add the device data that has been asked by Frenck in other Tuya Issues, as that would help us figuring out what your device needs.

Done: #59946

@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants