Rflink group commands

[aequitas]

Description: Support for group commands (allon/alloff).

Related issue (if applicable): fixes #5965

[mention-bot]

@aequitas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff to be a potential reviewer.

[aequitas]

@Lampy09 can you verify if this works for you?

[aequitas]

This PR is based on: #5869

[lajuffermans]

Thanks for the quick implementation, I'll test this tonight :)

[lajuffermans]

@aequitas it does 'work', however a group command is more like an alias for Kaku's. For example, the first time you set up a light you assign a regular on/off and (optionally) the group all_on/all_off. So a light in the same range doesn't have to be assigned necessarily to the group button.

In the current implementation you assume all lights in the same range are 'paired' to the group button.

So maybe it's possible to register the group button so people can add them in the configuration as aliases? (or maybe I'm missing something)

[aequitas]

For my Kaku remote all lights respond when using the group switch. Even if they are not programmed explicitly with the group. Would have to double-check with a reset switch if it is not because of an old programming. But I'm pretty sure this is the expected behaviour.

[lajuffermans]

Maybe a hardware difference? I'm using this remote: https://www.klikaanklikuit.nl/nl/ayct-102-afstandsbediening.html

It's not very clear in the manual but I had to assign/program the receivers I wanted to listen to the group key explicitly. And that's how it works for me know I have 4 receivers:
newkaku_AAAA_1
newkaku_AAAA_2
newkaku_AAAA_3
newkaku_AAAA_4

And only 2 and 3 are programmed to the group key.

[aequitas]

The manual doesn't state it clearly indeed. I have the same remote (or at least it looks the same) and an older model (wheel type). Will verify the behaviour of those later today or tomorrow. What receivers are you using? Maybe those make a difference?

[lajuffermans]

I use mixed receivers:

• A couple of ACD-300's
• An AWMR-200
• An ACM-1000

However, if I look into a similar remote manual it says:

Door de groeptoets “G” ook aan iedere
ontvanger toe te kennen, kunt u met één druk
op de knop al uw ontvangers (ook dimmers)
tegelijk aan of uitschakelen.

[aequitas]

The device I used for testing is: http://www.homewizard.nl/media/wysiwyg/handleiding/APA3-1500R%20Gebruiksaanwijzing.pdf

This is sold as 3 switches with one remote. The remote only has an off group button. Which sends out the alloff on the first switch channel. The switches also respond similar on allon alloff commands from other non apa3-1500R remotes.

I'm going to do some more debugging with other receivers and probably make the current implementation configurable and allow responding to group commands as well as normal on/off for devices.

[aequitas]

Vastly simplified group command support. Behavior of both group mechanisms (explicit register and implicit on first switch channel) can now be enabled by adding an alias. Also added some changes that will potentially solve issues mentioned in #5965

[lajuffermans]

Interesting thing btw, the group switch uses the same 'switch' (id) as switch 1:

DEBUG:rflink.protocol:received data: A;NewKaku;ID=009d1be6;SW DEBUG:rflink.protocol:received data: ITCH=1;CMD=ON; DEBUG:rflink.protocol:got packet: 20;0A;NewKaku;ID=009d1be6;SWITCH=1;CMD=ON; DEBUG:rflink.protocol:decoded packet: {'id': '009d1be6', 'command': 'on', 'node': 'gateway', 'switch': '1', 'protocol': 'newkaku'} DEBUG:rflink.protocol:got event: {'id': 'newkaku_009d1be6_1', 'command': 'on'} newkaku_009d1be6_1 on

DEBUG:rflink.protocol:received data: 20;0B;NewKaku;ID=009d1be DEBUG:rflink.protocol:received data: 6;SWITCH=1;CMD=ALLON; DEBUG:rflink.protocol:got packet: 20;0B;NewKaku;ID=009d1be6;SWITCH=1;CMD=ALLON; DEBUG:rflink.protocol:decoded packet: {'id': '009d1be6', 'command': 'allon', 'node': 'gateway', 'switch': '1', 'protocol': 'newkaku'} DEBUG:rflink.protocol:got event: {'id': 'newkaku_009d1be6_1', 'command': 'allon'} newkaku_009d1be6_1 allon

So how would it even be possible to use the group key as an alias?

[aequitas]

Correct, but it depends on the remote. I have one remote where there is no other button that uses the 1 switch and another that has the first button also as switch one.

Aliases can be used multiple times for different devices. You can even assign an ID for a device as an alias for another.

[lajuffermans]

So in my situation, how am I able to alias the group switch?

newkaku_009d1be6_1:
  name: Dining
  type: dimmable
newkaku_009d1be6_2:
  name: Corner
  type: dimmable
newkaku_009d1be6_3:
  name: Television
  type: dimmable

The funny thing is, 'television' & 'corner' are the only 2 lights linked to the group switch, which is 'newkaku_009d1be6_1' in my case. Putting 'newkaku_009d1be6_1' as an alias under 'corner' doesn't make sense right? Because if I turn on/off 'dining', it will also turn off 'corner' for example.

Or am I missing something?

[aequitas]

True, that is one shortcoming I already foresaw. I have some ideas on how to fix this but don't know which one would be best in order to work with all cases but keep configuration simple an logical.

Easiest for now is to not use button '1' ;)

[lajuffermans]

Maybe it's an idea to use 'newkaku_009d1be6' (without switch numbers) as aliases?
So if an allon/alloff event is triggered, check if 'newkaku_009d1be6' is used as alias somewhere, if true turn them on/off. If no aliases are found, turn all lights on/off like you've had implemented before?

(I'm not sure what the possibilities are or what the impact on other devices is ;) )

[andrey-git]

Any updates on this PR?

[aequitas]

I'm gonna come back on this PR in a few days.

[houndci-bot]

line too long (103 > 79 characters)

[houndci-bot]

missing whitespace after ','
line too long (91 > 79 characters)

[aequitas]

@Lampy09 i pushed an update. Can you test if this works for you?

config example:

newkaku_009d1be6_2:
  name: Dining
  type: dimmable
  group_aliasses:
    - newkaku_009d1be6_1

[lajuffermans]

It's basically working, however in my situation I still have the individual light (dining) which is also listening to the group command, example of my config:

newkaku_009d1be6_1:
  name: Dining
  type: dimmable
newkaku_009d1be6_2:
  name: Corner
  type: dimmable
  group_aliasses:
    - newkaku_009d1be6_1
newkaku_009d1be6_3:
  name: Television
  type: dimmable
  group_aliasses:
    - newkaku_009d1be6_1

Theoretically the state of 'dining' shouldn't switch on/off when 'newkaku_009d1be6_1' all_on/all_off is sent.

[aequitas]

Ah, yes. Let me see how we can fix that.

[lajuffermans]

Installed 0.41.0.dev0 (pip3 install --upgrade git+git://github.com/aequitas/home-assistant@rflink_group_commands)

However I'm unable to send rflink commands from home assistant (state doesn't change, light isn't turned on/off). It's still receiving commands when I use my remote.....

[aequitas]

@Lampy09 I just updated the branch against the latest upstream. Can you try again? Can you also paste you config?

[lajuffermans]

I think it's related to Home Assistant 0.40.0 and higher. 0.39.3 is working like expected.
I'll try to do some more investigation tomorrow.

[aequitas]

There is currently a issue with 0.40 maybe its affecting your setup to: #6580

[lajuffermans]

Hi @aequitas, is this testable again? Since #6580 is fixed/released in 0.40.1?

[aequitas]

Can you try again now?

[lajuffermans]

@aequitas I can confirm it's working like expected 👍

[Spartan-II-117]

Is this ready for merge?

[aequitas]

Yes, ready.

[balloob]

💃 🐬