Rename zeroconf service info#59467
Conversation
|
|
||
|
|
||
| class HaServiceInfo(TypedDict): | ||
| class ZeroconfServiceInfo(TypedDict): |
There was a problem hiding this comment.
Or maybe we could use ZeroconfDiscoveryInfo to match the generic DiscoveryInfoType?
| class ZeroconfServiceInfo(TypedDict): | |
| class ZeroconfDiscoveryInfo(TypedDict): |
There was a problem hiding this comment.
I think the current suggestion (ZeroconfServiceInfo) is fine. It matches what is represented in Zeroconfig itself.
If anything, I would maybe even call it just "ServiceInfo", as it is already in the Zeroconf package namespace.
There was a problem hiding this comment.
Should I wait for @bdraco to confirm that he too prefers just ServiceInfo?
I've marked the other PRs as draft until this one gets merged.
There was a problem hiding this comment.
I like the ZeroconfServiceInfo name because there are some integrations that have multiple discovery sources and it will easier to differentiate with something like SSDPServiceInfo, DHCPserviceInfo.
There was a problem hiding this comment.
I'm ok with that :)
Do you approve otherwise @bdraco ?
Proposed change
Rename HaServiceInfo to ZeroconfServiceInfo.
As discussed in #58958 (comment)
cc @frenck @bdraco @KapJI
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: