Skip to content

Remove illuminance from Xiaomi zhimi.airfresh.va2 sensors#59305

Merged
rytilahti merged 1 commit intohome-assistant:devfrom
bieniu:xiaomi_miio/airfresh.va2
Nov 7, 2021
Merged

Remove illuminance from Xiaomi zhimi.airfresh.va2 sensors#59305
rytilahti merged 1 commit intohome-assistant:devfrom
bieniu:xiaomi_miio/airfresh.va2

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Nov 7, 2021

Breaking change

Proposed change

zhimi.airfresh.va2 doesn't support illuminance sensor so this PR removes it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bieniu bieniu added this to the 2021.11.2 milestone Nov 7, 2021
@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bieniu bieniu changed the title Remove illuminance sensor from Xiaomi Miio zhimi.airfresh.va2 Remove illuminance from Xiaomi zhimi.airfresh.va2 sensors Nov 7, 2021
Copy link
Copy Markdown
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rytilahti rytilahti merged commit c85db9a into home-assistant:dev Nov 7, 2021
@bieniu bieniu deleted the xiaomi_miio/airfresh.va2 branch November 8, 2021 14:41
balloob pushed a commit that referenced this pull request Nov 9, 2021
@balloob balloob mentioned this pull request Nov 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miio fan sensors unavalible

6 participants