Guard against missing data in ReCollect Waste#59177
Merged
frenck merged 2 commits intohome-assistant:devfrom Nov 6, 2021
Merged
Guard against missing data in ReCollect Waste#59177frenck merged 2 commits intohome-assistant:devfrom
frenck merged 2 commits intohome-assistant:devfrom
Conversation
55546e6 to
f9998e3
Compare
f9998e3 to
add1606
Compare
frenck
approved these changes
Nov 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Some ReCollect Waste users have seasonal pickups, which means that when out of season, the API doesn't return any data. This PR guards against this scenario by ensuring the entity gets marked as unavailable.
The PR also takes the opportunity to remove a not-needed
timeimport.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: